-
Notifications
You must be signed in to change notification settings - Fork 0
update tonkeeper wallet docs #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Thanks for the Tonkeeper doc update — I focused on the single changed page and found several high‑severity safety and correctness items to address before merge. Findings (6)High (6)[HIGH] Missing safety callout for mnemonic handlingLocation:
Description: Suggestion: -<Tip>The recovery phrase is the only way to restore access to your wallet if the app is deleted or your device is lost. Make sure to save it in a secure place.</Tip>
+<Warning title="Keys and funds at risk">
+Losing or exposing your 24-word recovery phrase allows account takeover and permanent loss of funds. Store it offline in a secure place. Rollback: none — access cannot be restored without the exact phrase.
+</Warning> [HIGH] Missing safety callout for entering mnemonicLocation:
Description: Suggestion: Tonkeeper requires a mainnet wallet before creating a testnet account. The testnet account derives from your existing wallet's [mnemonic](link-to-mnemonic-article).
+
+ <Aside type="warning" title="Secrets at risk — mnemonic">
+ Entering your 24-word recovery phrase exposes sensitive wallet keys.
+ Scope: your wallet and any derived accounts. Mitigation: enter the mnemonic only on trusted devices; do not store it in plaintext or share it. Environment: use TON Testnet for testing; avoid using a mainnet mnemonic outside your wallet app.
+ </Aside>
To add a testnet account: [HIGH] Missing safety callout for funds transferLocation: mintlify-ton-docs/ecosystem/wallet-apps/tonkeeper.mdx Lines 75 to 78 in 888a9c6
Description: Suggestion: Once you have coins in your wallet:
+
+ <Aside type="warning" title="Funds at risk — use testnet">
+ Sending a transaction moves funds and is irreversible.
+ Scope: the selected wallet/account. Mitigation: test on TON Testnet first; verify the recipient and amount before confirming. Environment: prefer testnet; on mainnet, transfers are final and cannot be rolled back.
+ </Aside>
1. Open Tonkeeper and tap **Send** [HIGH] Missing safety callout for NFT transfers (irreversible action)Location: mintlify-ton-docs/ecosystem/wallet-apps/tonkeeper.mdx Lines 82 to 91 in 888a9c6
Description: Suggestion: -Always double-check all the transaction information. Once the transaction is complete, you cannot undo it. Once confirmed, the NFT will be transferred to the recipient's wallet.
+<Warning title="Transfers are final">
+NFT transfers on TON Mainnet are irreversible. Verify the recipient address and collection details before confirming. Test on TON Testnet first if possible. Rollback: none — on-chain transfers are final.
+</Warning> [HIGH] Broken image paths to non-existent subfolderLocation: mintlify-ton-docs/ecosystem/wallet-apps/tonkeeper.mdx Lines 7 to 12 in 888a9c6
Description: Suggestion: -<img
- src="/resources/images/tonkeeper/Tonkeeper.png"
+<img
+ src="/resources/images/Tonkeeper.png"
alt="Main dashboard interface"
height="300"
className="rounded-lg"
/> -<img
- src="/resources/images/tonkeeper/backup.png"
- alt="Backup recovery phrase"
+<img
+ src="/resources/images/Tonkeeper.png"
+ alt="Tonkeeper screenshot (placeholder)"
height="50%"
className="rounded-lg"
/> -<img
- src="/resources/images/tonkeeper/testnet-account.jpg"
- alt="Add Testnet Account"
+<img
+ src="/resources/images/Tonkeeper.png"
+ alt="Tonkeeper screenshot (placeholder)"
height="300"
className="rounded-lg"
/> [HIGH] Placeholder/broken links for mnemonic and faucetLocation:
Description: Suggestion: -Tonkeeper requires a mainnet wallet before creating a testnet account. The testnet account derives from your existing wallet's [mnemonic](link-to-mnemonic-article).
+Tonkeeper requires a mainnet wallet before creating a testnet account. The testnet account derives from your existing wallet's [mnemonics](/standard/wallets/mnemonics). -To deploy your wallet, you need TON. For testnet, you can request free coins from the [TON testnet faucet](link-to-testnet-coins-guide).
+To deploy your wallet, you need TON. For testnet, request free coins from the [TON testnet faucet](https://t.me/testgiver_ton_bot). -- [How to get testnet coins](link-to-testnet-coins-guide)
+- [How to get testnet coins](https://t.me/testgiver_ton_bot) |
@fakela Which issue/issues does this PR resolve? Please see https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix the in-place comments and the relevant AI comments too
|
||
Once the transaction is confirmed, your wallet contract will be deployed on-chain and become active. You can verify this by checking your wallet address on the [Testnet explorer](https://testnet.tonscan.org/). | ||
|
||
## Transfer NFTs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why only NFTs? what about jettons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, the description needs to have illustrations for each step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend covering the Traces-related explanation in the corresponding assets (NFTs, Jettons). For example, we have a jetton section; let's explain how transfer works there with screenshots of Tonviewer or even self-drawn images.
Additionally, it will be more useful for those who want to understand how asset transfer works at a high level and how to track this in explorers.
Reason: Different wallets will display varying information, which may change monthly, and we can't guarantee that the information is up-to-date here.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
To fix the formatting issues:
npx remark -o --silent --silently-ignore ecosystem/wallet-apps/tonkeeper.mdx |
Closes #587
Closes #137
There is a missing link to the how to get testnet section. It might be added now or once the #599 is merged.