General cleanup and refactoring #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since both classes implement Comparable<Rectangle>, their compareTo implementations have to be compatible (previously the result of comparing a Rectangle with an RTL TextChunk depended on which compareTo implementation happened to be used).
Removed several redundant casts and type parameters
jazzido
requested changes
Sep 14, 2017
| return this.getText(new Rectangle(top, left, right - left, bottom - top)); | ||
| } | ||
|
|
||
| public Integer getRotation() { | ||
| /** @deprecated with no replacement */ | ||
| @Deprecated public Integer getRotation() { |
There was a problem hiding this comment.
This is used in the App: https://github.com/tabulapdf/tabula/blob/master/lib/tabula_java_wrapper.rb#L102
jazzido
approved these changes
Sep 14, 2017
|
Merged. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done some work towards removing the use of sorting when not 100% appropriate (see #116).
Also, removed unnecessary generic type parameters (eg:
List<X> = new ArrayList<X>()) and done some general housekeeping.I've deprecated a few methods in Page that I'm not actually sure aren't used by dependants (ie: the tabula app).
Changes should be source-compatible with the original version (unless I messed up) - not binary compatible I fear.