Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression from 0.9.2: undetected rulings #174

Closed
jazzido opened this issue Jul 28, 2017 · 1 comment
Closed

Regression from 0.9.2: undetected rulings #174

jazzido opened this issue Jul 28, 2017 · 1 comment

Comments

@jazzido
Copy link
Contributor

jazzido commented Jul 28, 2017 •
edited
Loading

I caught this almost by chance. We have a test case, but the assertions are not correct: it passes because the number of rulings is >0, but the coordinates are b0rked.

0.9.2

image

1.0.1-SNAPSHOT

image

We're likely not applying a transformation to the detected rulings.
@jazzido
Copy link
Contributor Author

jazzido commented Jul 28, 2017

Corrected assertion in 105603f (fix/174)

jazzido added a commit that referenced this issue Jul 28, 2017
@jazzido
Account for non-(0,0) CropBoxes — Fixes #174
d8d9804
@jazzido jazzido mentioned this issue Jul 28, 2017
Merged
jazzido added a commit that referenced this issue Jul 28, 2017
@jazzido
Account for non-(0,0) CropBoxes — Fixes #174
9f62c30
EmpowerZ pushed a commit to EmpowerZ/tabula-java that referenced this issue Oct 23, 2020
@jazzido
Account for non-(0,0) CropBoxes — Fixes tabulapdf#174
f966eae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jazzido