Support specify hash algorithm in files.add #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
changed the title
alanshaw
force-pushed
the
files-add-hash-alg1
branch
from
634fca1
to
3f64347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify multihash hashing alogrithm
This allows the optional param
--hash(CLI) or?hash=(HTTP API) to be passed tofiles.addin order to specify the hash algorithm that should be used when generating the multihash(es) for the added content.Passing this option will set the CID version option to
true, as per the Go implementation.Change
object/getandobject/datato accept CIDsThis brings js-ipfs more in line with go-ipfs. Where both
object/getandobject/dataaccept a CID. It's also needed byjs-ipfs-apiwhen adding files (see further discussion in tableflip/js-ipfs-api#2).requires tableflip/js-ipfs-api#2