Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "this application can't be opened" error on opening tabcmd.app on Mac #285

Merged
merged 20 commits into from
May 3, 2024

Conversation

renoyjohnm
Copy link
Contributor

Issue: "This application can't be opened" error was encountered on using the tabcmd.app on Mac environment from release artifacts

Resolution: The app wasn't properly bundled and the zip of the bundle associated with actions/upload-artifact@v4 github action led to loss of executable file's +x permission and eventually led to aforementioned error while using the app. This PR addresses this issue by tar-ing the app bundle before uploading it to artifact thereby preserving the necessary file permissions

@renoyjohnm renoyjohnm self-assigned this May 1, 2024
Copy link

salesforce-cla bot commented May 1, 2024

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Renoy John Marattukalam <r***@r***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@renoyjohnm renoyjohnm requested a review from jacalata May 1, 2024 20:56
Copy link

github-actions bot commented May 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py777 0%
   tabcmd.py141414 0%
   version.py633 50%
tabcmd/commands
   commands.py101010 0%
   constants.py721313 82%
   server.py1262626 79%
tabcmd/commands/auth
   session.py3604242 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1171313 89%
   delete_command.py601616 73%
   export_command.py1282828 78%
   get_url_command.py1896161 68%
   publish_command.py832525 70%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481313 73%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py2844 86%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2822 93%
   edit_site_command.py3822 95%
   list_command.py441010 77%
   list_sites_command.py3022 93%
tabcmd/commands/user
   create_site_users.py571010 82%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2203030 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1442424 83%
   localize.py6788 88%
   logger_config.py4266 86%
   tabcmd_controller.py3544 89%
TOTAL260744383% 

Copy link
Contributor

@stephendeoca stephendeoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ran the github action "Release-Executable" for the latest changes you should be good to merge.

@jacalata jacalata merged commit fa14810 into development May 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants