packaging update #279
Merged
packaging update #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have to pass the existing gate for 3.7 in order to delete it
contributing.md
Outdated
| ####To work with tabcmd, you need to have **Python 3.7+** installed. | ||
| ## Install Tabcmd | ||
| > [!NOTE] | ||
| > These instructions are for people who want to write code in or using tabcmd. If > you are interested in tabcmd but not the code, see [here](Readme.md). |
There was a problem hiding this comment.
I'm having some trouble understanding this line.
Also, I think there's a stray > in the 2nd sentence.
Co-authored-by: Andy Young <90729701+anyoung-tableau@users.noreply.github.com>
stephendeoca
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with pyinstaller v6 caused the executable to trigger automated malware alerts. Changing back to build with v5.13 gets an almost clean scan.
tabcmd 0.13 from github built with pyinstaller 6.x: ~30 vendors flagged it
https://www.virustotal.com/gui/file/829b092e47228c0cea2c54e0f75e63501b5e12135a76fef2dcbaba2deac228ed
my freshly built copy of 0.13 with pyinstaller 5.13: 2 vendors flagged it
https://www.virustotal.com/gui/file/b1c8be24ade44a8eae93e6a03d56fcd99caf389549c647fcb133b965d1c8e1f4/detection
tabcmd0.11.exe from github: was also built with 5.13: 1 vendor flaggged it
https://www.virustotal.com/gui/file/f6453b2549b9f696701e76d83b7c349a8710d3492a4fabf3029a6634c7f236f2