-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tfs 1482014 publishing #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacalata
commented
Dec 7, 2022
- implemented db username and password, oauth username, for publishing
- lots of improved debug messages
- fixed everywhere that was catching a BaseException
Start using the --db-username, etc arguments
also add some trace statements showing when we begin the export, fixed some switched arguments
This will also catch a system exit
ashwinar
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for making these changes. I saw e2e tests added, but I'm not sure how they run. Are those manual tests or they run in pipeline?
jacalata
added a commit
that referenced
this pull request
Dec 8, 2022
* Add Datasources to the Get Command (#162) * format command-specific help (#203) * hide token-value like we do password * Tfs 1482014 publishing (#205) * make db-auth/oauth mutually exclusive * Create a db credentials item for publishing with --db-username, etc arguments Co-authored-by: Brian Cantoni <bcantoni@salesforce.com> Co-authored-by: Bhuvnesh Singh <bhuvnesh.singh@salesforce.com> Co-authored-by: andyoneal <andyoneal@me.com>
jacalata
added a commit
that referenced
this pull request
Dec 16, 2022
* make db-auth/oauth mutually exclusive * Create a db credentials item for publishing with --db-username, etc arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.