Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tfs 1482014 publishing #205

Merged
merged 12 commits into from
Dec 7, 2022
Merged

Tfs 1482014 publishing #205

merged 12 commits into from
Dec 7, 2022

Conversation

jacalata
Copy link
Contributor

@jacalata jacalata commented Dec 7, 2022

  • implemented db username and password, oauth username, for publishing
  • lots of improved debug messages
  • fixed everywhere that was catching a BaseException

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py888 0%
   tabcmd.py121212 0%
tabcmd/commands
   commands.py101010 0%
   constants.py601111 82%
   server.py1262525 80%
tabcmd/commands/auth
   session.py2834242 85%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1103030 73%
   delete_command.py601616 73%
   export_command.py1272727 79%
   get_url_command.py1886363 66%
   publish_command.py651919 71%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4055 88%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py682626 62%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4699 80%
   delete_project_command.py3544 89%
   publish_samples_command.py2844 86%
tabcmd/commands/site
   create_site_command.py3677 81%
   delete_site_command.py3044 87%
   edit_site_command.py3822 95%
   list_command.py341818 47%
   list_sites_command.py3022 93%
tabcmd/commands/user
   create_site_users.py4655 89%
   create_users_command.py5244 92%
   delete_site_users_command.py4355 88%
   user_data.py2103030 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1402323 84%
   localize.py6788 88%
   logger_config.py4266 86%
   parent_parser.py7733 96%
   tabcmd_controller.py3755 86%
TOTAL245146181% 

Copy link

@ashwinar ashwinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for making these changes. I saw e2e tests added, but I'm not sure how they run. Are those manual tests or they run in pipeline?

@jacalata jacalata merged commit 35ff22a into development Dec 7, 2022
jacalata added a commit that referenced this pull request Dec 8, 2022
* Add Datasources to the Get Command (#162)
* format command-specific help (#203)
* hide token-value like we do password
* Tfs 1482014 publishing (#205)
* make db-auth/oauth mutually exclusive
* Create a db credentials item for publishing with --db-username, etc arguments

Co-authored-by: Brian Cantoni <bcantoni@salesforce.com>
Co-authored-by: Bhuvnesh Singh <bhuvnesh.singh@salesforce.com>
Co-authored-by: andyoneal <andyoneal@me.com>
jacalata added a commit that referenced this pull request Dec 16, 2022
* make db-auth/oauth mutually exclusive
* Create a db credentials item for publishing with --db-username, etc arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants