Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jac/delete site #202

Merged
merged 8 commits into from
Nov 29, 2022
Merged

Jac/delete site #202

merged 8 commits into from
Nov 29, 2022

Conversation

jacalata
Copy link
Contributor

functional changes

  1. change "continue if exists" to false, to match behavior of original tabcmd
  2. fix bug where we tried to call delete on the content url, not the site id
  3. make sure to clear the site name for the session when the server name changes
  4. run toLower on input so that comparisons with existing saved options is valid

This should fix Ashwin's bug where the command returned 0 even when it failed.
Also extracted strings for future translation
improved logging while debugging
Added a convenience option that just keeps going if an object to create already exists, but it changed the behavior from expected.
@github-actions
Copy link

github-actions bot commented Nov 28, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py777 0%
   tabcmd.py121212 0%
tabcmd/commands
   commands.py101010 0%
   constants.py591111 81%
   server.py1262525 80%
tabcmd/commands/auth
   session.py2834242 85%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py951919 80%
   delete_command.py591616 73%
   export_command.py1262727 79%
   get_url_command.py1524343 72%
   publish_command.py581717 71%
   runschedule_command.py2077 65%
tabcmd/commands/extracts
   create_extracts_command.py3955 87%
   decrypt_extracts_command.py2622 92%
   delete_extracts_command.py3666 83%
   encrypt_extracts_command.py2622 92%
   reencrypt_extracts_command.py2622 92%
   refresh_extracts_command.py672626 61%
tabcmd/commands/group
   create_group_command.py2855 82%
   delete_group_command.py2622 92%
tabcmd/commands/help
   help_command.py472626 45%
tabcmd/commands/project
   create_project_command.py4599 80%
   delete_project_command.py3444 88%
   publish_samples_command.py2744 85%
tabcmd/commands/site
   create_site_command.py3577 80%
   delete_site_command.py2944 86%
   edit_site_command.py3722 95%
   list_command.py331818 45%
   list_sites_command.py2922 93%
tabcmd/commands/user
   create_site_users.py4555 89%
   create_users_command.py5144 92%
   delete_site_users_command.py4255 88%
   user_data.py2103030 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1382323 83%
   localize.py6788 88%
   logger_config.py4066 85%
   parent_parser.py4633 93%
   tabcmd_controller.py3955 87%
TOTAL238245381% 

@jacalata jacalata merged commit 51d91b0 into development Nov 29, 2022
@jacalata jacalata deleted the jac/delete-site branch November 29, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants