Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make export use filters, add tests #164

Merged
merged 4 commits into from
Sep 1, 2022
Merged

make export use filters, add tests #164

merged 4 commits into from
Sep 1, 2022

Conversation

jacalata
Copy link
Contributor

  1. updated export command to look for filter params on the url given and convert them to RequestOption view_filters
  2. fixed bytes v iterator for data files.
  3. added tests

@github-actions
Copy link

github-actions bot commented Aug 24, 2022 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py777 0%
   tabcmd.py121212 0%
tabcmd/commands
   commands.py101010 0%
   constants.py401111 72%
   server.py1302727 79%
tabcmd/commands/auth
   session.py2784141 85%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py3477 79%
   delete_command.py591616 73%
   export_command.py1332323 83%
   get_url_command.py1524545 70%
   publish_command.py571616 72%
   runschedule_command.py2077 65%
tabcmd/commands/extracts
   create_extracts_command.py3955 87%
   decrypt_extracts_command.py2622 92%
   delete_extracts_command.py3666 83%
   encrypt_extracts_command.py2622 92%
   reencrypt_extracts_command.py2622 92%
   refresh_extracts_command.py672626 61%
tabcmd/commands/group
   create_group_command.py2855 82%
   delete_group_command.py2622 92%
tabcmd/commands/help
   help_command.py472626 45%
tabcmd/commands/project
   create_project_command.py4599 80%
   delete_project_command.py3444 88%
   publish_samples_command.py2744 85%
tabcmd/commands/site
   create_site_command.py3577 80%
   delete_site_command.py2422 92%
   edit_site_command.py3722 95%
   list_command.py331818 45%
   list_sites_command.py2922 93%
tabcmd/commands/user
   create_site_users.py4555 89%
   create_users_command.py5144 92%
   delete_site_users_command.py4255 88%
   user_data.py1982121 89%
tabcmd/execution
   _version.py222 0%
   global_options.py1362323 83%
   localize.py5788 86%
   parent_parser.py4633 93%
   tabcmd_controller.py3444 88%
TOTAL224942181% 

@jacalata jacalata mentioned this pull request Aug 27, 2022
Closed
anyoung-tableau
anyoung-tableau reviewed Aug 29, 2022
View reviewed changes
tabcmd/commands/datasources_and_workbooks/export_command.py Outdated
except BaseException as e:
logger.error("Error building filter params", e)
ExportCommand.log_stack(logger) # type: ignore
return request_options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to return request_options here? I'm assuming the original request_options argument passed in will have its view_filters field updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, we do not. Fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this one still pending?

@jacalata
respond to feedback
0642be3 
rename method, remove println, also add smoother handling for unnecessary / character
@jacalata
fix duplicated test name
bc8cb3c
@jacalata
actually remove return value
b67f082
@jacalata jacalata merged commit 6722d61 into development Sep 1, 2022
@jacalata jacalata deleted the jac/filter branch September 9, 2022 21:00
jacalata added a commit that referenced this pull request Sep 12, 2022
@jacalata
Release 2.0.6 (#172)
6fd4331 
* --save-db-password flag thinks it should get an argument
*updated several other publishing arguments that had the same problem
* change argument from "token" to "token-value" so it is not a substring of "token-name", remove the 2-letter short arguments
* fix reencrypt_extracts help string
* Hand format a nice help output
* Fix exit_with_error handling
* Defect 1426885: [Tabcmd WAM] addusers and removeusers error
* fix deletegroup
* update unlocalized strings
* clearly indicate when using the default site
* Fix export success log message params (#142)
* Jac/tfs 1428582 create edit site (#146)
* Getting workbook works as expected, but appends extra file extensions
* Fix get view, get csv (#143)
* Change install destination (#150)
* Defect 1428581: [Tabcmd WAM] Publishing to projects other than default throws an error
* Jac/delete command (#144)
* filter for items in project
* separate the use of ds/wb as flags vs as argument names
* update publish_samples to call shared project logic
* Add command to list items of a given content type (#153)
* make export use filters, add tests (#164)
* Add trace logging details and error stack
* handle url input more robustly
Co-authored-by: Brian Cantoni <bcantoni@salesforce.com>
Co-authored-by: Bhuvnesh Singh <bhuvnesh.singh@salesforce.com>
jacalata added a commit that referenced this pull request Nov 10, 2022
@jacalata @bcantoni @bhuvneshdev
code for 2.07 (#196)
842168a 
Dropped support for python < 3.9
Changed argument from "token" to "token-value" so it is not a substring of "token-name", remove the 2-letter short arguments

Release 2.0.6
* add step to list dependencies for licensing
* Defect 1427376: [Tabcmd WAM] --save-db-password flag thinks it should get an argument (#134)
* Fix exit_with_error handling (#137)
* TFS 1428581 publish project (#139)
* Defect 1426885: [Tabcmd WAM] addusers and removeusers error, fix deletegroup (#140)
* clearly indicate when using the default site (#141)
* Fix export success log message params (#142)
* Jac/tfs 1428582 create edit site (#146)
* Fix get view, get csv file extensions (#143)
* Change install destination to /tabcmd instead of /src (#150)
* Defect 1428581: [Tabcmd WAM] Publishing to projects other than default throws an error  (#145)
* Jac/delete command (#144)
* Jac/e2e test workflow (#154)
* Add command to list items of a given content type (#153)
* make export use filters, add tests (#164)
* Fix some e2e tests (#166)
* Trace logging and bug fix (#165)

Release 2.0.7
* Implement command line and url parameters for get/export (#175)
* recognize more values for yes on command line (#173)
* fully port to pyproject.toml (#182)
* implement pdf layout/page type (#184, #169)
* tfs 1427025: Confusing error message related to sign-in (#187), (#190)
* stop duplicate logging in session
* extract encryption defaults to false (#193)
* call sites endpoint correctly (#194)
* publish data source to Tableau Cloud for published live connection with Tableau Bridge (#195)

Co-authored-by: Brian Cantoni <bcantoni@salesforce.com>
Co-authored-by: Bhuvnesh Singh <bhuvnesh.singh@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyoung-tableau anyoung-tableau anyoung-tableau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacalata @anyoung-tableau