Skip to content

Commit

Permalink
chore: remove pending DynamicNewBadge
Browse files Browse the repository at this point in the history
  • Loading branch information
tabarra committed Apr 4, 2024
1 parent d878ee9 commit b275c0a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion docs/dev_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

## Chores + refactor
- [x] update packages
- [ ] remove pending DynamicNewBadge
- [x] remove pending DynamicNewBadge
- [ ] add new modal (page?) for adding legacy ban
- could plan this in a way that fits some other configs/tools that is not exactly settings page?
- [ ] Remove old live console legacy code
Expand Down
5 changes: 0 additions & 5 deletions panel/src/layout/DesktopNavbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import MainPageLink from '@/components/MainPageLink';
import { cva } from 'class-variance-authority';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';
import { useAdminPerms } from '@/hooks/auth';
import DynamicNewBadge from '@/components/DynamicNewBadge';

const buttonVariants = cva(
`group inline-flex h-10 w-max items-center justify-center rounded-md px-4 py-2 text-sm font-medium transition-colors focus:outline-none disabled:pointer-events-none disabled:opacity-50 ring-offset-background focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2`,
Expand Down Expand Up @@ -82,13 +81,9 @@ export default function DesktopHeader() {
<NavigationMenuList>
<HeaderMenuLink href="/players">
Players
{/* FIXME: remove */}
<DynamicNewBadge featName='newPlayersPage' />
</HeaderMenuLink>
<HeaderMenuLink href="/history">
History
{/* FIXME: remove */}
<DynamicNewBadge featName='newHistoryPage' />
</HeaderMenuLink>
<HeaderMenuLink href="/whitelist">
Whitelist
Expand Down
3 changes: 0 additions & 3 deletions panel/src/pages/LiveConsole/LiveConsoleFooter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { cn, openExternalLink } from "@/lib/utils";
import { BookMarkedIcon, FileDownIcon, SearchIcon, Trash2Icon } from "lucide-react";
import { useAdminPerms } from '@/hooks/auth';
import { useLiveConsoleHistory } from '@/hooks/liveConsole';
import DynamicNewBadge from '@/components/DynamicNewBadge';


type ConsoleFooterButtonProps = {
Expand All @@ -30,8 +29,6 @@ function ConsoleFooterButton({ icon: Icon, title, disabled, onClick }: ConsoleFo
<span className="hidden 2xl:inline ml-1 align-middle">
{title}
</span>
{/* FIXME: remove */}
{title === 'Saved' && <DynamicNewBadge featName='liveConsoleBookmarks' />}
</div>
)
}
Expand Down

0 comments on commit b275c0a

Please sign in to comment.