Skip to content

Commit

Permalink
fix(panel): warning bar scrolling up with page
Browse files Browse the repository at this point in the history
  • Loading branch information
tabarra committed Aug 31, 2024
1 parent 4030732 commit 9bfce52
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions docs/dev_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,16 @@
- [x] check if the client print issues have been solved
- https://github.com/citizenfx/fivem/commit/cafd87148a9a47eb267c24c00ec15f96103d4257
- https://github.com/citizenfx/fivem/commit/84f724ed04d07e0b3a765601ad19ce54412f135b
- [x] the WarningBar scrolls up with the pages when they have scroll
- [ ] fix the message `Since this is not a critical file, ...` on first boot without txData
- from `SvRuntimeStatsManager` and `PlayerDropStatsManager`
- [ ] implement `.env`
- Use with chokidar on `main-builder.js` to restart the build
- Maybe pass it through so I could use it for the server as well
- Don't forgor to update `development.md`
- [ ] fix txDiagnostics (and add tx v8 heap data to it)
- [ ] update packages
- [ ] update wouter and add search/filters state to URL of the players/history pages
- [ ] Use `dotenv` or something to configure `main-builder.js` and update `development.md`
- [ ] add `.yarn.installed` to the dist? even in dev
- [ ] check if chat PRs were merged, and start migrating recipes to use `resources_useSystemChat`
- [ ] check netid uint16 overflow
Expand Down Expand Up @@ -187,7 +193,6 @@ for log in statsLog:
- [ ] add average session time tracking to statsManager.playerDrop

- Small feats, fix, and improvements:
- [ ] the WarningBar scrolls up with the pages when they have scroll
- [ ] locale file optimization - build 8201 and above
- [ ] easter egg???
- some old music? https://www.youtube.com/watch?v=nNoaXej0Jeg
Expand Down
2 changes: 1 addition & 1 deletion panel/src/layout/WarningBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function InnerWarningBar({ titleIcon, title, description, isImportant, ca

if (canPostpone && !checkPostponeStatus(isImportant)) return null;
return (
<div className='absolute top-[calc(3.5rem+1px)] w-full flex justify-center z-40'>
<div className='fixed top-[calc(3.5rem+1px)] w-full flex justify-center z-40'>
<div className={cn(
"w-full sm:w-[28rem] h-9 hover:h-32 overflow-hidden sm:rounded-b-md",
"flex flex-col justify-center items-center p-2",
Expand Down

0 comments on commit 9bfce52

Please sign in to comment.