Responsive height main navigation #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-navigation. - fixed positioning of touch button in main-navigation - fixed positioning of small arrow in _open-sub-menu-link (main-navigation) when using dropdownColumns
|
@dmh I noticed I ran "grunt production" here, which uglifies css and js (and it seems it wasn't before). Is it better that I change this to "grunt compileLess && grunt compileCss" for these pull-requests? |
|
@pxamike Yes, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request contains a new less-variables: nav-height-md that by default inherits nav-height, but by setting an unique-value you can control the height of main-navigation (and all other items that are placed there) in desktop. It will still keep its default nav-height in the hamburger-menu in tablet and smaller.
It has been tested with most of the theme configurations concerning main-navigation (language menu, search) enabled as well as with touch-mode enabled. No new theme constant has however been added.
In the screenshots below, @nav-height-md is 100px, contrary to @nav-height's ordinary 60px.