-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warnings when running pitest task with Gradle 6.0 #155
Comments
@szpak Could you please fix it? |
I had a discussion with the Gradle guys about that and we didn't reach a consensus. I will try to make the second attempt to make it supported in Gradle (I would like to have that variable as both input and output - for different parts on the execution) or sort out how to solve it in the other way. |
As I can see, right now only |
It the output of the task. Some other task re-use that. That was the initial idea to mark it as |
Btw, I recalled why I haven't fixed those warnings back in September. It would remove the plugin compatibility with Gradle <5.6. See here and there. 5.5.1 was released on Jun 28, 2019 - just a hair over half year ago which is quite sad (when it was just 3 months). Nevertheless, the world moves forward and I will make a switch. |
I have encountered gradle/gradle#12351, but luckily Stefan provided a workaround. @remal @embee1981 Please test the latest snapshot which should by Gradle6-related warnings.
|
This warning has been fixed, but another one occurs. I have a multi-module Gradle project.
|
I'm afraid, I'm not sure if this commit is about my case or not. I suppose that the cause is that you use |
That multi-module sample project (in the devel branch) used in the functional tests doesn't generate any warnings with Gradle 6.x. Please share share a link to you project (if available), modify mine to generate a warning or provide some other minimal which could be used to determine where the problem is. |
I'm using buildscript {
// ...
configurations.maybeCreate('pitest')
dependencies {
classpath 'info.solidsoft.gradle.pitest:gradle-pitest-plugin:1.4.6'
pitest 'org.pitest:pitest-junit5-plugin:0.8'
}
} Also I run Gradle with Looks like pitest gradle plugin tries to resolve I'm not sure why I have this issue and your test doesn't generate it, but, as I understand, Gradle doesn't like resolving configurations from other projects. The project I'm working on is not an open-source, so I can give you the link. |
To eliminate configurations.maybeCreate("pitest")
dependencies {
pitest "org.pitest:pitest-command-line"
pitest "org.pitest:pitest-junit5-plugin"
}
tasks.pitest.configure {
launchClasspath = project.configurations.pitest
} |
Yes, it does. I'm glad you've found a workaround on that. The idea to do not use the root project for the pitest configuration is not new - #62. I plan to take a look at it. However, most likely it will not be backward compatible, so as the other - more common - warnings seem to be fixed I plan to release 1.4.7 soon. @remal as a JUnit 5 user you might also benefit (to some degree) from #177. |
And thanks for getting into the problem in your project. |
@szpak thanks for this :-) , new version of plugin has reduced the deprecation warnings, just the one left for me (multi project setup, "The configuration :pitest was resolved without accessing the project in a safe manner.", gradle 6.2.1). Think you've got a bug open for this one though. |
Yes, #62. Btw, do you have tests in a separate module or just like |
When running the "pitest" task with Gradle 6.0 I get the following warnings (ensure "all" warnings are show, eg via gradle.properties file with org.gradle.warning.mode=all ):
The text was updated successfully, but these errors were encountered: