Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer imported URL to the global one #50

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

xamgore
Copy link
Contributor

@xamgore xamgore commented Aug 21, 2020

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #50 into master will increase coverage by 1.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   83.11%   85.03%   +1.91%     
==========================================
  Files          15       14       -1     
  Lines         764      795      +31     
==========================================
+ Hits          635      676      +41     
+ Misses        129      119      -10     
Impacted Files Coverage Δ
source/agent.js 98.62% <100.00%> (-1.38%) ⬇️
source/auto.js 100.00% <100.00%> (ø)
source/client-request.js 100.00% <100.00%> (ø)
source/proxies/h1-over-h2.js 23.68% <100.00%> (+2.06%) ⬆️
source/proxies/h2-over-h1.js 14.81% <100.00%> (+1.60%) ⬆️
source/proxies/h2-over-h2.js 13.63% <100.00%> (+2.00%) ⬆️
source/index.js 100.00% <0.00%> (ø)
source/incoming-message.js 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ee5ff...9ff3b75. Read the comment docs.

.xo-config.json Outdated
{
"files": "source/{**,}.js",
"rules": {
"node/prefer-global/url": ["error", "never"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use // eslint-disable-next-line node/prefer-global instead.

Copy link
Contributor Author

@xamgore xamgore Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be 7 places with the comment and new files may not import URL properly. Are you totally sure? Maybe it's preferred to set node/prefer-global/url for the whole project (also tests) to simplify the rule above?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be 7 places with the comment

That's the point. So when it's fixed we don't forget to remove this workaround.

Are you totally sure?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using typescript, jest and http2:true causes RequestError: connect ECONNREFUSED 127.0.0.1:443
3 participants