This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Fix for Object Cache 'Get' method incorrectly setting cache value #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #438 wherein
wp_cache_getshows$foundto betrueeven it is directly preceded by awp_cache_delete.The issue lies in the
getfunction inObjectCache_WpObjectCache_Regular.php, which always sets a value for the cache object's key, even if a hit was not found.The proposed fix is to only set
$this->cache[$key] = $value;if$value !== false