This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Page Cache - "Accepted Query Strings" Enhancement #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiga-500
changed the title
szepeviktor
pushed a commit
that referenced
this pull request
May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page Cache's Accepted Query Strings box has always felt limited. Query strings are composed of a series of field-value pairs. Up to this point W3TC's Accepted Query Strings box only analyzed field names and completely ignored their associating values. It also was not as efficient as it could have been when Disk: Enhanced mode was used.
This update hopefully improves the experience by offering two new enhancements:
It allows the user to provide (optionally) a value, in the form:
name=value. Acceptable example entries could be:utm_source=Newsletter,utm_medium=,utm_campaignIf Disk: Enhanced is enabled it leverages the user's htaccess (or nginx.conf) file to determine if the requesting query string URL contains only one or more acceptable query string name-value pairs. If it does then the request page proceeds to being cached or served a cached page. Prior to this, all query string URLs, regardless of the page cache disk mode used, would need to boot up the W3TC backend for processing. Performance-wise, it was not the ideal workflow.