This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Malformed HTML in Generated Item UIs (Admin Pages) #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiga-500
changed the title
|
Eath time we make a fix i sead a mail to w3tc support for infom it. Just for curiosity, you already send a mail? I want avoid double communications. |
|
Hi @nigrosimone . Nope i have never sent them an email nor communicated with them ever. So, all good. I've only been updating the Wiki page with the fixes, updates, and new features. I assume you are letting them know about the new features and updates too, not just the bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Util_Ui::config_itemfunction and setting it's style attribute to 2 (this tells it to span two columns for its container table header), it causes the HTML to be malformed, resulting in the generated<label>tag to be inserted incorrectly, potentially destroying the page layout in less popular (or older) browsers, which might even include Internet Explorer. This fix resolves the problem and the page validates correctly.For those reading and curious what the problem looks like, here is a snapshot -- note the red area: