Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load contact fields used in templates via APIv4 #43

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

dontub
Copy link
Contributor

@dontub dontub commented Apr 16, 2024

Contact fields like email_greeting_display aren't returned via APIv3, anymore.

systopia-reference: 24737

Contact fields like `email_greeting_display` aren't returned via APIv3,
anymore.
@dontub dontub requested a review from jensschuppe April 16, 2024 15:41
Copy link
Collaborator

@jensschuppe jensschuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you find out since which Core version this behavior changed? This should be added to the README and release notes of the current (note about incompatibility) and next (note about compatibility) stable version.

@dontub
Copy link
Contributor Author

dontub commented Apr 17, 2024

Looking at the code, I couldn't find out when this changed...

@jensschuppe
Copy link
Collaborator

Could you add a generic note to the README and the releases notes then?

@dontub
Copy link
Contributor Author

dontub commented Apr 17, 2024

It's added to README.md.

You mean the github release notes?

@jensschuppe
Copy link
Collaborator

You mean the github release notes?

Yes, because that's where we primarily have them, see this example.

@dontub dontub merged commit ccd3923 into master Apr 17, 2024
@dontub dontub deleted the load-template-fields-via-APIv4 branch April 17, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants