Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 Compatibility #28

Closed
2 tasks done
abugey opened this issue Nov 2, 2022 · 2 comments · Fixed by #30
Closed
2 tasks done

PHP 8.0 Compatibility #28

abugey opened this issue Nov 2, 2022 · 2 comments · Fixed by #30
Labels
enhancement status:fixed The issue has been resolved (usually by committing/merging code)
Milestone
1.1

Comments

@abugey
Copy link
Contributor

abugey commented Nov 2, 2022 •
edited
Loading

  • Analyse code regarding PHP 8 compatibility
  • Fix deprecations found (to be specified)
@jensschuppe jensschuppe added this to the 1.1 milestone Nov 25, 2022
abugey added a commit that referenced this issue Nov 28, 2022
@abugey
[#28] updated CustomDataHelper
179ef62
@abugey abugey added the status:fixed The issue has been resolved (usually by committing/merging code) label Nov 28, 2022
@abugey
Copy link
Contributor Author

abugey commented Nov 28, 2022

nothing to fix, just updated CustomDataHelper

@abugey abugey closed this as completed Nov 28, 2022
@abugey abugey reopened this Nov 28, 2022
@abugey abugey linked a pull request Nov 28, 2022 that will close this issue
PHP 8 compatibility #29
Merged
jensschuppe added a commit that referenced this issue Nov 29, 2022
@jensschuppe
Merge branch 'issue/28_php8'
7f46712 
[#28] PHP 8 compatibility
@abugey abugey reopened this Dec 13, 2022
@abugey
Copy link
Contributor Author

abugey commented Dec 13, 2022

Errors in PHP 8.0:
CustomData.php: Ilegal array key type in lines 708, 709, 730, 732, 735: [$field_id]

@abugey abugey removed a link to a pull request Jan 5, 2023
PHP 8 compatibility #29
Merged
abugey added a commit that referenced this issue Jan 5, 2023
@abugey
[#28] fixed Custom Data Helper
5d4e909
@abugey abugey linked a pull request Feb 7, 2023 that will close this issue
[#28] fixed Custom Data Helper #30
Merged
@abugey abugey closed this as completed in #30 Feb 7, 2023
abugey added a commit that referenced this issue Feb 7, 2023
@abugey
Merge pull request #30 from systopia/issue/28_php8_reopened
bc37c8b 
[#28] fixed Custom Data Helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

[#28] fixed Custom Data Helper systopia/de.systopia.moregreetings
2 participants
@jensschuppe @abugey