Fix issues with some operators in activity report #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a number of issues with the "Is not one of", "Is empty (Null)" and "Is not empty (Null)" operators for the "Campaign(s)", "Assigned To" and "Created By" fields. These operators previously did not work as the generated SQL was invalid. Additionally, for the "Is not one of" operator, the query was changed so it included values with a NULL value, which is consistent with core behaviour.
|
Looks good, thanks @pfigel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of issues with the "Is not one of", "Is empty (Null)" and "Is not empty (Null)" operators for the "Campaign(s)", "Assigned To" and "Created By" fields. These operators previously did not work as the generated SQL was invalid.
Additionally, for the "Is not one of" operator, the query was changed so it included values with a
NULLvalue, which is consistent with core behaviour.This also ensures that values are properly escaped for SQL.