Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Civix-generated code to Civix version 23.02.1 #193

Merged
merged 1 commit into from
May 10, 2024
Merged

Upgrade Civix-generated code to Civix version 23.02.1 #193

merged 1 commit into from
May 10, 2024

Conversation

jensschuppe
Copy link
Collaborator

@jensschuppe jensschuppe commented Apr 2, 2024 •
edited
Loading

Fixes PHP notices with Smarty 3:

Notice: Indirect modification of overloaded property CRM_Core_Smarty::$template_dir has no effect in _donrec_civix_civicrm_config() (line 107 of /path/to/civicrm/extensions/de.systopia.donrec/donrec.civix.php).

This should be merged for 2.3 into the current master and cherry-picked for 2.2.

@jensschuppe jensschuppe added bug status:needs review Code needs review and testing. labels Apr 2, 2024
@jensschuppe jensschuppe added this to the 2.2 milestone Apr 2, 2024
@jensschuppe jensschuppe linked an issue Apr 9, 2024 that may be closed by this pull request
Compatibility with CiviCRM 5.69.2 / Smarty V3 #189
Closed
@jensschuppe jensschuppe mentioned this pull request Apr 9, 2024
Closed
@sluc23
Copy link

sluc23 commented Apr 17, 2024

it works!

@jensschuppe jensschuppe added status:reviewed and tested Code has received thorough review and testing and is ready to be committed/merged. and removed status:needs review Code needs review and testing. labels Apr 17, 2024
@sluc23
Copy link

sluc23 commented Apr 18, 2024

@jensschuppe / @bjendres any ETA for releasing a new version with civix upgraded.. we are in CiviCRM5.69 with Smarty3 and this issue raise errors in several other places in Civi (View Contribution page not accesible.. etc). tx!

jensschuppe
jensschuppe commented Apr 18, 2024
View reviewed changes
info.xml Show resolved Hide resolved
@jensschuppe jensschuppe modified the milestones: 2.2, 2.3 Apr 18, 2024
@jensschuppe jensschuppe merged commit 7b3a011 into master May 10, 2024
@jensschuppe jensschuppe deleted the civixUpgrade branch May 10, 2024 10:35
@jensschuppe jensschuppe added status:fixed The issue has been resolved (usually by committing/merging code). and removed status:reviewed and tested Code has received thorough review and testing and is ready to be committed/merged. labels May 10, 2024
This was referenced Jun 20, 2024
Closed
Merged
@jensschuppe jensschuppe modified the milestones: 2.3, 2.2 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sluc23 sluc23 sluc23 left review comments

Assignees
No one assigned
Labels
bug status:fixed The issue has been resolved (usually by committing/merging code).
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Compatibility with CiviCRM 5.69.2 / Smarty V3
2 participants
@jensschuppe @sluc23