Do not overwrite the issued_on field when copying a donation receipt

[MarcMichalsky]

As discussed here, the issued_on field should not be overwritten when copying a donation receipt. This ensures that a copy bears the correct and original date of its issuance.

Apart from preserving the original issued_on date this PR also adjusts the default template to use the $issued_on variable instead of $today. Otherwise the change wouldn't have any effect.

Important

If you are using a custom donation receipt template, you will need to make the above adjustments yourself! You can edit your templates within the Donation Receipts Profiles (Administer -> Administration Console -> Donation Receipts Profiles -> edit). Find all $today variables and simply replace them with $issued_on.

fix #169

[jensschuppe]

@bjendres I'm not sure whether this should go into a 2.2 point release or a new 2.3 minor one. Would this silently introduce a change for people only using the default template (which might be very few, but still ...)?

[MarcMichalsky]

Here's my two cents: people should know that they need to read the release notes before upgrading.

[bjendres]

Looks good (and simple enough) to me.

@jensschuppe, would have another look?

[bjendres]

Here's my two cents: people should know that they need to read the release notes before upgrading.

Yes....but they don't :)

[jensschuppe]

Would this silently introduce a change for people only using the default template (which might be very few, but still ...)?

This is actually not a problem as Donation Receipts profiles don't use "real" message templates anymore, so an update to the default template will not affect existing profiles.

[jensschuppe]

Just noticed that this was only merged into master for 2.3. Cherry-picked it into the release/2.2.x branch just now, as was intended.