Always cache the default tools tree #3612
Merged
+46
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's not return the mkosi specific directory, but the wider runtime directory.
Let's simplify and mount in the entirety of /home, /run and the invoking user's environment to make stuff just work more often than not and avoid too many implementation details of specific tools leaking into mkosi itself.
Let's simplify things and make the entirety of /home available. The relaxed sandbox is not about security, and permissions already make sure only the user's own home can be accessed.
For the default tools tree, the cached image and the final image are the same for all intents and purposes, so let's stop storing both a cached image and a final image for the default tools tree and instead only store the final image and use it as the cached image by always writing a cache manifest next to it. At the same time always use the name mkosi.tools to reduce the chance of conflicts as "tools" is an incredibly common directory name.
behrmann
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the default tools tree, the cached image and the final image
are the same for all intents and purposes, so let's stop storing both
a cached image and a final image for the default tools tree and instead
only store the final image and use it as the cached image by always
writing a cache manifest next to it.
At the same time always use the name mkosi.tools to reduce the chance
of conflicts as "tools" is an incredibly common directory name.