Speed up kernel modules initrd generation if no excludes were specified #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
force-pushed
the
kmod
branch
3 times, most recently
from
5b07975
to
4eac7d0
Compare
If no excludes were specified, we can just glob all modules and firmware without going via modinfo. We can only do this if no firmware was installed as otherwise we end up copying firmware into the initrd that's not depended on by any kernel modules.
behrmann
approved these changes
Mar 6, 2024
septatrix
reviewed
Mar 17, 2024
| # There is firmware in /usr/lib/firmware that is not depended on by any modules so if any firmware was installed | ||
| # we have to take the slow path to make sure we don't copy firmware into the initrd that is not depended on by any | ||
| # kernel modules. | ||
| if exclude or not (root / "usr/lib/firmware").glob("*"): |
There was a problem hiding this comment.
The not seems to be erroneous, see #2521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.