Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanups #125

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Misc cleanups #125

merged 2 commits into from
Dec 13, 2024

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Dec 7, 2024

  • readme: fix method used for flashing System76 EC
  • rework Make targets
  • add missing SPDX IDs
  • handle installing toolchain with rustup 1.28.0
  • replace win64 with efiapi for ABI
  • clippy
    • ignore: dead_code
    • ignore: clippy::missing_transmute_annotations
    • fix: clippy::unnecessary_get_then_check

Does not address static_mut_refs, which will be a hard error in the 2024 edition.

NOTE: The default target is changed from the FAT32 image to the UEFI application. Scripts relying on the default target will need to be updated.

@crawfxrd crawfxrd marked this pull request as ready for review December 9, 2024 15:53
@crawfxrd crawfxrd requested review from jackpot51 and a team December 9, 2024 15:54
- readme: fix method used for flashing System76 EC
- rework Make targets
- add missing SPDX IDs
- handle installing toolchain with rustup 1.28.0
- replace win64 with efiapi for ABI
- clippy
  - ignore: `dead_code`
  - ignore: `clippy::missing_transmute_annotations`
  - fix: `clippy::unnecessary_get_then_check`

Does not address `static_mut_refs`, which will be a hard error in the
2024 edition.

NOTE: The default target is changed from the FAT32 image to the UEFI
application. Scripts relying on the default target will need to be
updated.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd merged commit 2325f02 into master Dec 13, 2024
2 checks passed
@crawfxrd crawfxrd deleted the cleanup branch December 13, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants