Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redox_uefi_std to 0.1.13 #109

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Update redox_uefi_std to 0.1.13 #109

merged 3 commits into from
Nov 11, 2024

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented May 30, 2024

This version will allow compiling using a stable toolchain.

@crawfxrd crawfxrd force-pushed the redox-uefi-stable branch 3 times, most recently from d002a00 to c7ba91b Compare May 30, 2024 18:42
@crawfxrd crawfxrd force-pushed the redox-uefi-stable branch 4 times, most recently from 331de53 to 3e1ab89 Compare June 10, 2024 17:07
@crawfxrd crawfxrd force-pushed the redox-uefi-stable branch from 3e1ab89 to fa568e1 Compare June 28, 2024 15:51
This version will allow compiling using a stable toolchain.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
Use the correct target for clippy as unwind features and symbols are no
longer used in redox_uefi_std. Fixes:

    error: unwinding panics are not supported without std

Also update the runner to ubuntu-24.04.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd changed the title Update redox_uefi_std Update redox_uefi_std to 0.1.13 Nov 9, 2024
@crawfxrd crawfxrd marked this pull request as ready for review November 9, 2024 02:39
@crawfxrd crawfxrd requested review from jackpot51 and a team November 9, 2024 02:39
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a small problem with this update. To test, I flashed a lemp13-b from a USB created from firmware-open with this branch checked out in apps/firmware-update. It flashes successfully, but I get an error upon the first reboot:
IMG_20241111_135018_565
Each reboot would bring me back to this screen with this error, until I removed the USB. I imagine an internal update would be stuck in this loop until the efi boot entries get manually fixed, since there would be no USB to remove.

After this, I checked master back out in apps/firmware-update and rebuilt the firmware and re-flashed my USB. The error went away after flashing this time:
IMG_20241111_140036_295

@crawfxrd
Copy link
Member Author

I wonder if it has to do with the fact the previously warnings were ignored and treated as success, and now they are errors if used as a Result.

IIUC, redox_uefi_std opens the file as READ_ONLY, so FatPkg fails to delete it with EFI_WRITE_PROTECTED (which then gets returned as EFI_WARN_DELETE_FAILURE).

The other tag files are created and deleted from firmwash.nsh.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that did the trick!

IMG_20241111_153019_305

@jackpot51 jackpot51 merged commit 1a37d68 into master Nov 11, 2024
2 checks passed
@jackpot51 jackpot51 deleted the redox-uefi-stable branch November 11, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants