-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redox_uefi_std to 0.1.13 #109
Conversation
d002a00
to
c7ba91b
Compare
331de53
to
3e1ab89
Compare
3e1ab89
to
fa568e1
Compare
This version will allow compiling using a stable toolchain. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Use the correct target for clippy as unwind features and symbols are no longer used in redox_uefi_std. Fixes: error: unwinding panics are not supported without std Also update the runner to ubuntu-24.04. Signed-off-by: Tim Crawford <tcrawford@system76.com>
fa568e1
to
1f6d220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a small problem with this update. To test, I flashed a lemp13-b from a USB created from firmware-open with this branch checked out in apps/firmware-update. It flashes successfully, but I get an error upon the first reboot:
Each reboot would bring me back to this screen with this error, until I removed the USB. I imagine an internal update would be stuck in this loop until the efi boot entries get manually fixed, since there would be no USB to remove.
After this, I checked master
back out in apps/firmware-update and rebuilt the firmware and re-flashed my USB. The error went away after flashing this time:
I wonder if it has to do with the fact the previously warnings were ignored and treated as success, and now they are errors if used as a IIUC, The other tag files are created and deleted from |
Signed-off-by: Tim Crawford <tcrawford@system76.com>
c01490d
to
aa60a66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version will allow compiling using a stable toolchain.