Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system-firmware.md #1243

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Update system-firmware.md #1243

merged 3 commits into from
Aug 14, 2024

Conversation

esplinr
Copy link
Contributor

@esplinr esplinr commented Aug 1, 2024

Make clear what happens if the firmware updater is run with external devices plugged in.

@jacobgkau jacobgkau requested a review from a team August 1, 2024 16:18
@esplinr
Copy link
Contributor Author

esplinr commented Aug 8, 2024

Is there anything else I need to do for this contribution to be accepted?

@jacobgkau jacobgkau requested review from a team and removed request for jacobgkau August 14, 2024 17:03
Make clear what happens if the firmware updater is run with external devices plugged in.
Incorporating feedback
jacobgkau
jacobgkau previously approved these changes Aug 14, 2024
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think this is necessary (do we need to explain what happens at every step if the user doesn't follow the instructions?), but I guess it could help someone recognize what's wrong if they accidentally leave something plugged in and are only thinking about the symptom.

To try and keep these bullet points from getting so unwieldy people skim them over without really reading them, I've separated the tangential information into sub-bullet points.

@jacobgkau
Copy link
Member

@ahoneybun You replaced one linter issue with another. Let me take a look at what it needs.

@ahoneybun ahoneybun marked this pull request as ready for review August 14, 2024 19:02
@ahoneybun ahoneybun merged commit a2940fb into system76:master Aug 14, 2024
3 checks passed
@esplinr esplinr deleted the patch-1 branch August 15, 2024 22:12
@esplinr
Copy link
Contributor Author

esplinr commented Aug 15, 2024

Thank you for merging. This problem has repeatedly caught me off-guard since I bought my laptop from System76. Hopefully having the hint be explicit will help me remember next time. I agree that it would be much better for the updater to show an error instead of silently restarting. The current behavior is baffling if you don't remember what a successful update should look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants