Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on Issue 971 #1138

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Work on Issue 971 #1138

merged 7 commits into from
Aug 3, 2023

Conversation

ahoneybun
Copy link
Member

No description provided.

@n3m0-22
Copy link
Contributor

n3m0-22 commented May 25, 2023

Is this ready for review or are you still working on it? I'm still seeing the 404.

@ahoneybun
Copy link
Member Author

Should be fine, what 404?

@n3m0-22 n3m0-22 self-assigned this Jun 1, 2023
@n3m0-22 n3m0-22 requested review from a team June 1, 2023 16:37
n3m0-22
n3m0-22 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why I had an issue the other day, but I am no longer seeing it. The rest of these changes look good to me.

leviport
leviport requested changes Aug 2, 2023
View reviewed changes
content/live-disk.md Outdated Show resolved Hide resolved
content/pop-incomplete-upgrade.md Outdated Show resolved Hide resolved
leviport
leviport approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

thomas-zimmerman
thomas-zimmerman approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates. LGTM

@thomas-zimmerman thomas-zimmerman merged commit b37deac into master Aug 3, 2023
3 checks passed
@thomas-zimmerman thomas-zimmerman deleted the promote-recovery branch August 3, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobgkau jacobgkau jacobgkau left review comments

@n3m0-22 n3m0-22 n3m0-22 approved these changes

@leviport leviport leviport approved these changes

@thomas-zimmerman thomas-zimmerman thomas-zimmerman approved these changes

Assignees

@n3m0-22 n3m0-22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahoneybun @n3m0-22 @jacobgkau @leviport @thomas-zimmerman