Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention that /core doesn't add global styles #2333

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

lachlanjc
Copy link
Member

Fixes #2235 via an added docs line. Hopefully writing a new package for #2207 will make this a better DX for real.

@lachlanjc lachlanjc added the documentation Changes only affect the documentation label Oct 1, 2022
@lachlanjc lachlanjc requested a review from hasparus as a code owner October 1, 2022 06:23
@lachlanjc lachlanjc linked an issue Oct 1, 2022 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Oct 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
theme-ui ✅ Ready (Inspect) Visit Preview Oct 1, 2022 at 6:25AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2bc6a09:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

Copy link
Member

@hasparus hasparus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hasparus hasparus merged commit cd8ee39 into develop Oct 4, 2022
@hasparus hasparus deleted the 2235-core-mention-no-globals branch October 4, 2022 14:10
@hasparus
Copy link
Member

hasparus commented Oct 4, 2022

🚀 PR was released in v0.15.2 🚀

@hasparus hasparus added the released This issue/pull request has been released. label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's not obvious that @theme-ui/core doesn't apply styles.root.
2 participants