docs: Update Contributing doc with pnpm info #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4294b35:
|
lachlanjc
changed the title
hasparus
reviewed
Sep 18, 2022
packages/theme-ui/README.md
Outdated
| @@ -116,7 +116,7 @@ scales help you build UI rooted in constraint-based design principles. | |||
| npm install theme-ui @emotion/react | |||
| ``` | |||
|
|
|||
| _If you don't need color modes, components and MDX support, you can install | |||
| _If you don't need color modes, components, or MDX support, you can install | |||
There was a problem hiding this comment.
Suggested change
| _If you don't need color modes, components, or MDX support, you can install | |
| _If you don't need color modes or components you can install |
I missed this when I removed MDX from theme-ui. Everyone using it will now need to directly import @theme-ui/mdx.
hasparus
force-pushed
the
contributing-pnpm
branch
from
79c2a97 to
4294b35
Compare
hasparus
approved these changes
Sep 18, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.