Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(jsx): add some more detail to #with-swc section in jsx-pragma docs #2094

Merged
merged 2 commits into from
Jan 29, 2022
Merged

docs(jsx): add some more detail to #with-swc section in jsx-pragma docs #2094

merged 2 commits into from
Jan 29, 2022

Conversation

hasparus
Copy link
Member

I think folks are now interpretting this section of the docs as "remove your entire config and leave this one key" and you need other stuff in your config too.

@hasparus hasparus added the documentation Changes only affect the documentation label Jan 25, 2022
@hasparus hasparus requested a review from lachlanjc January 25, 2022 13:18
@vercel
Copy link

vercel bot commented Jan 25, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/GhAsCD4D43Gz6SEw88FkSRTw2oWn
✅ Preview: https://theme-ui-git-better-swc-pragma-docs-systemui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 25, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f597922:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

lachlanjc
lachlanjc approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I'd make theme-ui the default instead of core though, since I'd imagine most users are using the general package?

@lachlanjc
Copy link
Member

@hasparus Heads up that I switched it to theme-ui instead of @theme-ui/core by default since I think that applies to more folks. I don’t feel strongly though, happy to tweak.

@lachlanjc lachlanjc merged commit ccb6009 into develop Jan 29, 2022
@lachlanjc lachlanjc deleted the better-swc-pragma-docs branch January 29, 2022 18:27
@hasparus hasparus added the prerelease This change is available in a prerelease. label Jan 29, 2022
This was referenced Jan 29, 2022
Merged
Merged
This was referenced Feb 13, 2022
Merged
Merged
This was referenced Feb 20, 2022
Merged
Merged
Merged
This was referenced Mar 1, 2022
Merged
Merged
This was referenced Mar 16, 2022
Merged
Merged
Merged
@hasparus
Copy link
Member Author

🚀 PR was released in v0.14.0 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlanjc lachlanjc lachlanjc approved these changes

Assignees
No one assigned
Labels
documentation Changes only affect the documentation released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasparus @lachlanjc