Use media query value when useColorSchemeMediaQuery is set to 'system' #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And save to localStorage even if useColorScheme...: true, to make the flash prevention script work.
…-media-query-api-update
… types I felt that 'system' made a bit more sense here (over 'live') as we want to use the system color mode preference
implemented julianbenegas changes in the new index tsx file for color-modes
…eMediaQuery setting
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/HJc47wRw1gg8YDBqzeMCbiFVcipX |
…sting behaviour We only want it to ignore the stored value when useColorSchemeMediaQuery is system
|
Wow, phenomenal work!! Haven't tested it out but looks great. Super appreciate the contribution. |
Thanks! I'm loving the library so wanted to see if I could contribute. Keep up the great work!! |
hasparus
reviewed
Oct 25, 2021
|
Great PR @draekien! Thank you for the contribution! |
Co-authored-by: Piotr Monwid-Olechnowicz <hasparus@gmail.com>
lachlanjc
approved these changes
Oct 25, 2021
|
🚀 PR was released in |
hasparus
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the changes proposed in #981 and fixes #787
This change adds a new option for
useColorSchemeMediaQuerycalled'system'which willlisten for changes to the
prefers-color-schememedia query and update the color modeaccordingly.
This change also updates the documentation to include a short description for the
'system'option.I decided to go with
'system'over'live'as I've mostly encountered websites referring to theuser's preferred color scheme as the 'system' setting. Let me know if you would prefer
'live'instead.Testing:
'system'Testing:
'initial'|true