-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate mdx/Styled #1461
chore: deprecate mdx/Styled #1461
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/3RckQWdL45MNesG9qtY2ULnVmgbz |
Let's add a line to CHANGELOG as well 👍 |
True - will you add it or me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments. Just marking this here so I don't merge it accidentally.
Co-authored-by: Piotr Monwid-Olechnowicz <hasparus@gmail.com>
The only reason not to test things is so we can build more things faster—let’s absolutely add tests for that kind of thing too. We can always remove them later very easily |
Co-authored-by: Piotr Monwid-Olechnowicz <hasparus@gmail.com>
In my book, it's an overkill to spend any more time on a deprecated component that will be pulled out soon, while it holds back a stable release. Btw there is a small test |
I assume that if we're deprecating something, we'll keep it to next stable "major" release. |
Bring back Styled but with a console warning. The code is a bit hacky, but couldn't come up with anything better.