Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate mdx/Styled #1461

Merged
merged 13 commits into from
Mar 19, 2021

Conversation

atanasster
Copy link
Collaborator

Bring back Styled but with a console warning. The code is a bit hacky, but couldn't come up with anything better.

@atanasster atanasster requested a review from hasparus as a code owner January 23, 2021 16:35
@vercel
Copy link

vercel bot commented Jan 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/3RckQWdL45MNesG9qtY2ULnVmgbz
✅ Preview: https://theme-ui-git-fork-atanasster-deprecate-mdx-styled-systemui.vercel.app

@lachlanjc
Copy link
Member

Let's add a line to CHANGELOG as well 👍

@atanasster
Copy link
Collaborator Author

Let's add a line to CHANGELOG as well 👍

True - will you add it or me?

packages/mdx/src/index.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@hasparus
Copy link
Member

hasparus commented Jan 24, 2021

Do you guys think it would be an overkill to test it?

image

We already have a bunch of tests testing warning messages. We could keep up this tradition.

Copy link
Member

@hasparus hasparus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments. Just marking this here so I don't merge it accidentally.

Co-authored-by: Piotr Monwid-Olechnowicz <hasparus@gmail.com>
@lachlanjc
Copy link
Member

Do you guys think it would be an overkill to test it?

The only reason not to test things is so we can build more things faster—let’s absolutely add tests for that kind of thing too. We can always remove them later very easily

Co-authored-by: Piotr Monwid-Olechnowicz <hasparus@gmail.com>
@atanasster
Copy link
Collaborator Author

Do you guys think it would be an overkill to test it?

The only reason not to test things is so we can build more things faster—let’s absolutely add tests for that kind of thing too. We can always remove them later very easily

In my book, it's an overkill to spend any more time on a deprecated component that will be pulled out soon, while it holds back a stable release.

Btw there is a small test test('Deprecated Styled test'

@hasparus
Copy link
Member

a deprecated component that will be pulled out soon

I assume that if we're deprecating something, we'll keep it to next stable "major" release.

@hasparus hasparus requested a review from lachlanjc January 26, 2021 23:06
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants