WIP: Build packages with Preconstruct 2 #1423

hasparus · 2021-01-10T23:41:09Z

I made a few updates to #1204. Preconstruct is SO FAST comparing to our current microbundle setup.

To-Do

Release canary and test it in a few of my apps. (I'm kinda worried this change breaks something.)
Preconstruct seems to leave TypeScript's export type untouched in dev script. It should be compiled, and it is in build, but... This is weird. I'm not sure if it's a problem.
Fix config to make tests pass
Ignore tests in global typecheck and add typecheck:tests to prerelease script
Let's exclude editor from global typecheck, and add a separate tsconfig.json for it. I don't think it's worth to fix / work around type errors in it for now.
JSX namespace entrypoints are not resolved. (@theme-ui/core/jsx-dev-runtime)

📦 Published PR as canary version: 0.7.0--canary.1423.3d0dfed.0

✨ Test out this PR locally via:

npm install @theme-ui/color-modes@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/color@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/components@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/core@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/css@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/custom-properties@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/editor@0.7.0--canary.1423.3d0dfed.0
npm install gatsby-plugin-theme-ui@0.7.0--canary.1423.3d0dfed.0
npm install gatsby-theme-code-recipes@0.7.0--canary.1423.3d0dfed.0
npm install gatsby-theme-style-guide@0.7.0--canary.1423.3d0dfed.0
npm install gatsby-theme-ui-layout@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/match-media@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/mdx@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/parse-props@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-base@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-bootstrap@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-bulma@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-dark@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-deep@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-funk@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-future@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-polaris@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-roboto@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-sketchy@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-swiss@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-system@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-tailwind@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/preset-tosh@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/presets@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/prism@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/sidenav@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/style-guide@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/tachyons@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/tailwind@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/theme-provider@0.7.0--canary.1423.3d0dfed.0
npm install theme-ui@0.7.0--canary.1423.3d0dfed.0
npm install @theme-ui/typography@0.7.0--canary.1423.3d0dfed.0
# or 
yarn add @theme-ui/color-modes@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/color@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/components@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/core@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/css@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/custom-properties@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/editor@0.7.0--canary.1423.3d0dfed.0
yarn add gatsby-plugin-theme-ui@0.7.0--canary.1423.3d0dfed.0
yarn add gatsby-theme-code-recipes@0.7.0--canary.1423.3d0dfed.0
yarn add gatsby-theme-style-guide@0.7.0--canary.1423.3d0dfed.0
yarn add gatsby-theme-ui-layout@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/match-media@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/mdx@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/parse-props@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-base@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-bootstrap@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-bulma@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-dark@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-deep@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-funk@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-future@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-polaris@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-roboto@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-sketchy@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-swiss@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-system@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-tailwind@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/preset-tosh@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/presets@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/prism@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/sidenav@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/style-guide@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/tachyons@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/tailwind@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/theme-provider@0.7.0--canary.1423.3d0dfed.0
yarn add theme-ui@0.7.0--canary.1423.3d0dfed.0
yarn add @theme-ui/typography@0.7.0--canary.1423.3d0dfed.0

vercel · 2021-01-10T23:41:11Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/eackebd6g
✅ Preview: Failed

[Deployment for 6304630 failed]

hasparus · 2021-04-15T22:32:18Z

🚀 PR was released in v0.7.0-develop.0 🚀

alexanderchan and others added 23 commits November 7, 2020 13:55

Move index files to src

a53c276

Add preconstruct

7b011ce

Move index to src

f3f0284

Run preconstruct fix to update main

1ec654b

Fix mdx deps

7c0609c

Exclude docs from preconstruct packaging

a4d93d4

Add missing dependency

5fac4ae

Add a default module type

1b21a57

Fix type export

ef15d56

Remove unused files

3b51730

Run top level typecheck

1bf3af9

Add dev initialization

e50b126

Remove references to microbundle

976ba00

Update build to more closely match previous build

be1ee81

update yarn.lock

af19f9f

ignore top level theme-ui to prefer packages theme-ui

e485c09

Remove types reference since it comes from cjs.d.ts

2c0f2d3

Merge branch 'add/preconstruct' into preconstruct-2

9107006

wip(workspace): update to preconstruct 2

dda6fbf

test(theme-ui): stop spamming log with console.warn

5da9775

tools(preconstruct): fight config files to make tests pass

b8e8501

Merge branch 'develop' into preconstruct-2

e0b5b48

test(css): update to make tests typecheck in strict mode

7192e5d

hasparus requested review from lachlanjc and atanasster January 10, 2021 23:41

hasparus changed the title ~~Build packages with Preconstruct 2~~ WIP: Build packages with Preconstruct 2 Jan 11, 2021

tools(preconstruct): fix theme-ui entrypoints

f07f07c

vercel bot had a problem deploying to Preview January 11, 2021 00:17 Failure

fix(editor): fix type errors

9cc8261

hasparus removed request for lachlanjc and atanasster January 11, 2021 00:54

fix(preconstruct): fix entrypoints

c177969

hasparus requested review from atanasster and lachlanjc as code owners January 11, 2021 01:00

vercel bot had a problem deploying to Preview January 11, 2021 01:00 Failure

Merge branch 'develop' into preconstruct-2

293c45e

vercel bot had a problem deploying to Preview January 24, 2021 21:46 Failure

hasparus added 3 commits April 5, 2021 14:56

Merge branch 'develop' into preconstruct-2

6446f08

chore: fix theme-ui/css dependency version

e237378

chore: add missing dependency

7652cc0

vercel bot had a problem deploying to Preview April 5, 2021 13:56 Failure

hasparus added 3 commits April 5, 2021 16:02

chore: rename deprecated tsConfig option

ac62a1c

test: fix test types

a534b10

chore(typography): Move declarations.d.ts out of test dir

9579119

vercel bot had a problem deploying to Preview April 5, 2021 14:22 Failure

hasparus added 2 commits April 5, 2021 16:53

refactor(editor): fix type errors

7aa921b

chore(editor): annotate a type that should be inferred :(

de123b0

vercel bot had a problem deploying to Preview April 5, 2021 14:58 Failure

Merge branch 'develop' into preconstruct-2

1051c62

vercel bot had a problem deploying to Preview April 5, 2021 15:05 Failure

ci(scripts): remove all notion of prepare script

6304630

vercel bot had a problem deploying to Preview April 5, 2021 15:18 Failure

hasparus merged commit 3d0dfed into develop Apr 5, 2021

hasparus deleted the preconstruct-2 branch April 5, 2021 19:07

hasparus added the minor Increment the minor version when merged label Apr 5, 2021

hasparus added the prerelease This change is available in a prerelease. label Apr 15, 2021

dios-david mentioned this pull request Apr 30, 2021

jsx runtime is broken in v7 #1702

Closed

segunadebayo mentioned this pull request Nov 3, 2021

build: use microbundle to build packages chakra-ui/chakra-ui#4956

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Build packages with Preconstruct 2 #1423

WIP: Build packages with Preconstruct 2 #1423

hasparus commented Jan 10, 2021 •

edited

Loading

vercel bot commented Jan 10, 2021 •

edited

Loading

hasparus commented Apr 15, 2021

WIP: Build packages with Preconstruct 2 #1423

WIP: Build packages with Preconstruct 2 #1423

Conversation

hasparus commented Jan 10, 2021 • edited Loading

vercel bot commented Jan 10, 2021 • edited Loading

hasparus commented Apr 15, 2021

hasparus commented Jan 10, 2021 •

edited

Loading

vercel bot commented Jan 10, 2021 •

edited

Loading