Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color-modes): Default useColorModeMediaQuery to true #1373

Merged
merged 3 commits into from
Dec 21, 2020

Conversation

lachlanjc
Copy link
Member

Closes #624. Breaking change :)

@lachlanjc lachlanjc requested a review from hasparus as a code owner December 16, 2020 19:52
@vercel
Copy link

vercel bot commented Dec 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/rc440pdje
✅ Preview: https://theme-ui-git-default-color-scheme-true.systemui.vercel.app

Copy link
Member

@hasparus hasparus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@hasparus hasparus merged commit 4d67386 into system-ui:develop Dec 21, 2020
@lachlanjc lachlanjc deleted the default-color-scheme-true branch December 21, 2020 16:05
@lachlanjc
Copy link
Member Author

Ok, so all the checks were passing here so I didn’t investigate further, but it looks like this broke some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default useColorSchemeMediaQuery to true
2 participants