Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplications in RISC-V exception handlers #63

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Avoid duplications in RISC-V exception handlers #63

merged 1 commit into from
Oct 3, 2022

Conversation

Risheng1128
Copy link
Collaborator

@Risheng1128 Risheng1128 commented Oct 2, 2022 •
edited
Loading

Use preprocessor to avoid duplications in exception handlers,
and create a list to define the RISC-V exception code.

Resolve #61

jserv
jserv reviewed Oct 3, 2022
View reviewed changes
@Risheng1128
Copy link
Collaborator Author

Move the enumeration into source file.
Use X macro trick to construct the list.

jserv
jserv reviewed Oct 3, 2022
View reviewed changes
jserv
jserv reviewed Oct 3, 2022
View reviewed changes
jserv
jserv reviewed Oct 3, 2022
View reviewed changes
jserv
jserv requested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append Close #61 at the end of git commit message.

@Risheng1128
Avoid duplications in RISC-V exception handlers
21c09f0 
Use preprocessor to avoid duplications in exception handlers,
and create a list to define the RISC-V exception code.

Close sysprog21#61
@Risheng1128
Copy link
Collaborator Author

Risheng1128 commented Oct 3, 2022 •
edited
Loading

Becaue there are some exception handlers unused like insn_fault and
load_fault, I add the function attributes unused to prevent compiler
warning.

@jserv jserv merged commit fb0aa2c into sysprog21:master Oct 3, 2022
@jserv
Copy link
Contributor

jserv commented Oct 3, 2022

Thank @Risheng1128 for contributing!

@Risheng1128 Risheng1128 deleted the pr branch October 3, 2022 10:46
vestata pushed a commit to vestata/rv32emu that referenced this pull request Jan 24, 2025
@jserv
Merge pull request sysprog21#63 from Risheng1128/pr
0b9d294 
Avoid duplications in RISC-V exception handlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserv jserv jserv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid duplications in RISC-V exception handlers
2 participants
@Risheng1128 @jserv