Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The simplification of trigonometric and inverse trigonometric functions is not correct #662

Closed
sys27 opened this issue Jul 28, 2023 · 0 comments · Fixed by #665
Closed

The simplification of trigonometric and inverse trigonometric functions is not correct #662

sys27 opened this issue Jul 28, 2023 · 0 comments · Fixed by #665
Assignees
@sys27
Labels
bug
Milestone
xFunc 4.3.0

Comments

@sys27
Copy link
Owner

sys27 commented Jul 28, 2023 •
edited
Loading

Steps to reproduce the behavior:

  1. cos(arccos(-20)) returns NaN which is correct because the domain of arccos is -1 <= x <= 1.
  2. simplify(cos(arccos(-20))) returns -20. It doesn't take into account the domain of function.
@sys27 sys27 added the bug label Jul 28, 2023
@sys27 sys27 added this to the xFunc 4.3.0 milestone Jul 28, 2023
@sys27 sys27 self-assigned this Aug 1, 2023
sys27 added a commit that referenced this issue Aug 1, 2023
@sys27
#662 - The simplification of trigonometric and inverse trigonometric …
7debdc1 
…functions is not correct.
@sys27 sys27 mentioned this issue Aug 1, 2023
Merged
sys27 added a commit that referenced this issue Aug 2, 2023
@sys27
#662 - The simplification of trigonometric and inverse trigonometric …
9846d6d 
…functions is not correct.
sys27 added a commit that referenced this issue Aug 2, 2023
@sys27
#662 - The simplification of trigonometric and inverse trigonometric …
793b8c8 
…functions is not correct
sys27 added a commit that referenced this issue Aug 2, 2023
@sys27
#662 - The simplification of trigonometric and inverse trigonometric …
43c852c 
…functions is not correct
sys27 added a commit that referenced this issue Aug 2, 2023
@sys27
#662 - The simplification of trigonometric and inverse trigonometric …
66b8e53 
…functions is not correct.
sys27 added a commit that referenced this issue Aug 3, 2023
@sys27
#662 - The simplification of trigonometric and inverse trigonometric …
7e6144d 
…functions is not correct
sys27 added a commit that referenced this issue Aug 3, 2023
@sys27
#662 - The simplification of trigonometric and inverse trigonometric …
f761189 
…functions is not correct.
sys27 added a commit that referenced this issue Aug 3, 2023
@sys27
#662 - The simplification of trigonometric and inverse trigonometric …
001706c 
…functions is not correct.
@sys27 sys27 closed this as completed in #665 Aug 3, 2023
sys27 added a commit that referenced this issue Aug 3, 2023
@sys27
Merge pull request #665 from sys27/bugfix/662-simplification
8eaa07a 
#662 - The simplification of trigonometric and inverse trigonometric functions is not correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sys27 sys27

Labels
bug
Projects
None yet
Milestone
xFunc 4.3.0
1 participant
@sys27