fix: filtering of sub-queries

[fhur]

SynthQL pull request template

Why

Fixes https://github.com/orgs/synthql/projects/1/views/1?pane=issue&itemId=81880173

Summary by CodeRabbit

• New Features

  • Enhanced query-building process by allowing additional filtering criteria in joins.
  • Added a new test case for validating joins with WHERE clauses in the select functionality.

• Bug Fixes

  • Improved clarity and functionality of query conditions by filtering out reference operations.

• Documentation

  • Updated navigation and search data with new base64-encoded strings for improved content representation.

• Style

  • Refined test case formatting for better readability.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2024 11:05am

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes across multiple files related to query execution and testing in the backend. Key modifications include the addition of a where property to Join objects in tests, enhancements to the collectJoins and collectWhere functions, updates to the leftJoin method for incorporating filtering criteria, and the addition of a new test case for joins with a WHERE clause. Additionally, base64-encoded strings in navigation and search data have been updated, and minor formatting improvements have been made to existing test cases.

Changes

File	Change Summary
packages/backend/src/execution/executors/PgExecutor/queryBuilder/compareJoins.test.ts	Added where: {} property to three Join objects in the test cases.
packages/backend/src/execution/executors/PgExecutor/queryBuilder/createAugmentedQuery.ts	Enhanced collectJoins to filter out reference operations and simplified collectWhere.
packages/backend/src/execution/executors/PgExecutor/queryBuilder/exp.ts	Modified leftJoin method to include new where variable for SQL expressions from join.where.
packages/backend/src/execution/executors/PgExecutor/queryBuilder/types.ts	Updated import statement and added where property to Join type as AnyQuery['where'].
packages/backend/src/tests/e2e/select.test.ts	Added new test case join with where to check filtering by language in a join query.
packages/docs/static/reference/assets/navigation.js	Updated window.navigationData with a new base64-encoded string.
packages/docs/static/reference/assets/search.js	Updated window.searchData with a new base64-encoded string.
packages/queries/src/query.test.ts	Improved formatting of inline snapshots and query definitions in tests.

Possibly related PRs

• feat: added hashQuery() and used it in useSynthql() #41: The changes in iterateQuery.test.ts involve adding a hash property to the query structure, which is conceptually related to the addition of the where property in the compareJoins.test.ts file, as both modifications enhance the query structure.
• Deferred queries #52: The introduction of deferred queries in the composeExecutionResults.ts file may relate to the handling of joins and conditions in the compareJoins function, as both involve query processing and result handling.

🐰 "In the land of code where rabbits play,
New joins and where clauses brighten the day.
With tests that now dance and queries that sing,
A hop and a skip, let the changes take wing!
So gather 'round, friends, let's celebrate cheer,
For every new feature brings us all near!" 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.