Bump CQL dependencies #1163
Merged
Bump CQL dependencies #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are broken, but this commit does a few things: * Bumps most dependencies * Removes Spring as it was only used for RestClient * Uses OkHttp since it was already a transitive dependency Remaining issues are related to URL validation for value set expansion. Previous versions of the library were ok with things like `http://snomed.info/sct?fhir_vs=ecl/<<2491000087104`. Not so much anymore.
Fixed some of the cases where invalid characters for URLs are being used in value set expansion URLs
This bumps the various dependencies and handles an API change for how CQL is read in from ELM XML files (I think).
|
|
Codecov Report
@@ Coverage Diff @@
## master #1163 +/- ##
=========================================
- Coverage 80% 80% -1%
- Complexity 3425 3474 +49
=========================================
Files 135 135
Lines 22783 23506 +723
Branches 3090 3427 +337
=========================================
+ Hits 18237 18808 +571
- Misses 3588 3718 +130
- Partials 958 980 +22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jawalonoski
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies to the latest CQL libraries. The CQL that gets generated has been updated to reflect a change in the way that contexts work in CQL. Finally, there was a minor code change to handle an API difference in reading CQL.
This should be merged after #1144.