Add Sync, Start, and End classes for protocol 7 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synthead
added
enhancement
synthead
changed the title
|
Added a bullet point to document 0s packet sleep requirement in #151. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148!
This PR adds
Sync,Start, andEndclasses for protocol 7!This one is pretty clunky: it seems as if the DSI e-BRAIN (the device that uses protocol 7) has a bunch of required setup packets for both starting and ending the data transfer. These appear to be constant, so I have added them as hard-coded packets.
I also noticed that there are only 5 "sync 2" packets from the original software during the sync, so I opted to copy the data from the software and use 5 here, too. In testing, the 40 packets that are used in the other protocols do work, but I felt that it would be best to mimic the data verbatim.
Additionally, I also discovered that the
packet_sleepvalue must be 0 for data transfer to work. This will be a part of the documentation when it is added later.