Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You are referencing a package which has no license, cause it is a Joke Project (https://github.com/Raynos/not) #8

Closed
4 tasks done
haeferer opened this issue Oct 11, 2024 · 4 comments · Fixed by #9
Closed
4 tasks done

You are referencing a package which has no license, cause it is a Joke Project (https://github.com/Raynos/not) #8

haeferer opened this issue Oct 11, 2024 · 4 comments · Fixed by #9
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Comments

@haeferer
Copy link

Initial checklist

Affected packages and versions

6.0.2

Link to runnable example

No response

Steps to reproduce

Inspect the package.json for a reference to the "not" package in version 0.1.0

Expected behavior

All Sub Packages are licensed correctly

Actual behavior

Our licensing check Tool reports a "license not found" cause this joke-package has no license at all

Affected runtime and version

npm

Affected package manager and version

No response

Affected OS and version

No response

Build and bundle tools

No response
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 11, 2024
@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Oct 11, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Oct 11, 2024
@remcohaszing
Copy link
Member

Though I think the issue was put in a somewhat unrespectful manner, the not dependency is unused.

@wooorm
Copy link
Member

wooorm commented Oct 11, 2024

PR welcome

remcohaszing added a commit that referenced this issue Oct 11, 2024
@remcohaszing
Remove the dependency on not
25b86ae 
The `not` dependency is unused.

Closes #8
@remcohaszing remcohaszing mentioned this issue Oct 11, 2024
Merged
5 tasks
wooorm pushed a commit that referenced this issue Oct 11, 2024
@remcohaszing
Remove unused dependency not
bb9649b 
Related-to GH-8.
Closes GH-9.

Reviewed-by: Titus Wormer <tituswormer@gmail.com>
@wooorm wooorm closed this as completed in #9 Oct 11, 2024
@haeferer
Copy link
Author

Though I think the issue was put in a somewhat unrespectful manner, the not dependency is unused.

Sorry to all. I simply used the "issue form" which only includes direct questions, and no place to add a description or opinion. Respectful: you did a very good job by maintaining/ developing this. And answer so fast !

Best regard

Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the dependency on not syntax-tree/hast-util-select
3 participants
@remcohaszing @wooorm @haeferer