Skip to content

Commit

Permalink
fix: rename json key filepath.type to filepath.mode (#136)
Browse files Browse the repository at this point in the history
  • Loading branch information
ChunyiLyu authored May 22, 2024
1 parent e53a18c commit b859924
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
5 changes: 1 addition & 4 deletions api/v1alpha1/destination_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ type StateStoreCoreFields struct {

// DestinationSpec defines the desired state of Destination
type DestinationSpec struct {
// INSERT ADDITIONAL SPEC FIELDS - desired state of destination
// Important: Run "make" to regenerate code after modifying this file

// Path within StateStore to write documents, this will be appended to any
// specficed Spec.Path provided in the referenced StateStore.
// Kratix will then namespace any resources within the provided path.
Expand Down Expand Up @@ -76,7 +73,7 @@ type Filepath struct {
//The type of filepathExpression, either:
// - nestedByMetadata (default): files from the pipeline will be placed in a nested directory structure
// - none: file from the pipeline will be placed in a flat directory structure
Mode string `json:"type"`
Mode string `json:"mode"`
}

// it gets defaulted by the K8s API, but for unit testing it wont be defaulted
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/platform.kratix.io_destinations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
filepath:
description: The filepath mode to use when writing files to the destination.
properties:
type:
mode:
default: nestedByMetadata
description: |-
The type of filepathExpression, either:
Expand All @@ -55,7 +55,7 @@ spec:
- none
type: string
required:
- type
- mode
type: object
path:
description: |-
Expand Down

0 comments on commit b859924

Please sign in to comment.