-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add approximate support for GeLU #36
feat: Add approximate support for GeLU #36
Conversation
Hello @aturker-synnada, if we add a return, could the CI build pass, right? Looks like fails because of return, anything that I should be aware of? 😅 The other ‘on_failure’ CI pipeline seems to require credentials. How should we handle that? |
Yes, you are right 😅. I guess it is not about credentials; it should do something when CI failed @mehmetozsoy-synnada. |
Fixed mypy error and updated GeLU init arguments. |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 86.48% 86.51% +0.03%
==========================================
Files 61 61
Lines 15544 15600 +56
==========================================
+ Hits 13443 13497 +54
- Misses 2101 2103 +2
|
Description
GeLU now takes approximate flag as init argument. Closes #35.
What is Changed
Checklist: