Rename Role to RoleName to match user expierence #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We now consistently use `RoleName` for list output and fieldname - Expires column now always rounds down to the next minute. - If less than 1 minute remains, we display "< 1m" instead of empty string - Empty string denoting "expired" now says `Expired` to aid default sorting
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
+ Coverage 77.89% 78.12% +0.23%
==========================================
Files 24 24
Lines 2782 2811 +29
==========================================
+ Hits 2167 2196 +29
Misses 545 545
Partials 70 70
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoleNamefor list output and fieldnameExpiredto aid default sorting