Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FirstTag config option #494

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add support for FirstTag config option #494

merged 1 commit into from
Jul 28, 2023

Conversation

synfinatic
Copy link
Owner

Allows overriding the default sort order and place a specific tag at the top of the list.

Fixes: #445

@synfinatic synfinatic force-pushed the history-first branch 2 times, most recently from 8cdd46c to 0720705 Compare July 28, 2023 18:31
Allows overriding the default sort order and place a specific
tag at the top of the list.

- Bump to Go v1.19
- Bump to golangci-lint v1.52.2

Fixes: #445
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #494 (3cea235) into main (11f6527) will increase coverage by 0.01%.
The diff coverage is 80.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
+ Coverage   77.79%   77.79%   +0.01%     
==========================================
  Files          23       24       +1     
  Lines        2737     2756      +19     
==========================================
+ Hits         2129     2144      +15     
- Misses        539      543       +4     
  Partials       69       69              
Files Changed Coverage Δ
sso/settings.go 75.00% <ø> (ø)
internal/tags/logger.go 33.33% <33.33%> (ø)
sso/cache.go 50.12% <66.67%> (ø)
internal/tags/tags_list.go 95.79% <100.00%> (ø)
sso/config.go 74.79% <100.00%> (ø)
sso/roles.go 89.63% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f6527...3cea235. Read the comment docs.

@synfinatic synfinatic merged commit b4f0827 into main Jul 28, 2023
@synfinatic synfinatic deleted the history-first branch July 28, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to list History first in interactive menu
1 participant