Flush oudated roles/SSO instances from cache #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
+ Coverage 77.71% 77.79% +0.08%
==========================================
Files 23 23
Lines 2723 2737 +14
==========================================
+ Hits 2116 2129 +13
- Misses 538 539 +1
Partials 69 69
Continue to review full report in Codecov by Sentry.
|
synfinatic
force-pushed
the
fix-auto-flush-cache
branch
from
a22fb8b to
6702b6f
Compare
synfinatic
commented
Jul 28, 2023
synfinatic
force-pushed
the
fix-auto-flush-cache
branch
from
6702b6f to
e6952bb
Compare
Deleting or renaming an SSO instance in the config.yaml would result in those roles being left in the cache.json which would likely lead to conflicts when generating ~/.aws/config We now prune any oudated SSO instances from the cache when they are removed from the config.yaml Fixes: #479
synfinatic
force-pushed
the
fix-auto-flush-cache
branch
from
e6952bb to
01d5f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting or renaming an SSO instance in the config.yaml would result in those roles being left in the cache.json which would likely lead to conflicts when generating ~/.aws/config
We now prune any oudated SSO instances from the cache when they are removed from the config.yaml
Fixes: #479