Update cache faster via goroutines #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 78.34% 77.66% -0.68%
==========================================
Files 23 23
Lines 2613 2717 +104
==========================================
+ Hits 2047 2110 +63
- Misses 498 538 +40
- Partials 68 69 +1
Continue to review full report at Codecov.
|
synfinatic
force-pushed
the
cache-refresh
branch
5 times, most recently
from
bf95c37 to
0582979
Compare
synfinatic
force-pushed
the
cache-refresh
branch
4 times, most recently
from
ffc11a4 to
1aaa0c3
Compare
- Add `Threads` config option (default is 5) - Use goroutines to fetch role info from AWS - Let users know when fetching roles is taking a while. - Fix bug causing cache to be updated twice Fixes: #448
synfinatic
force-pushed
the
cache-refresh
branch
from
1aaa0c3 to
dda2409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threadsconfig option (default is 10)Fixes: #448