Context sensitive prediction #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synfinatic
force-pushed
the
predict-in-binary
branch
from
13ae09e to
0c1a6f4
Compare
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 76.09% 77.39% +1.30%
==========================================
Files 18 21 +3
Lines 2288 2517 +229
==========================================
+ Hits 1741 1948 +207
- Misses 480 496 +16
- Partials 67 73 +6
Continue to review full report at Codecov.
|
synfinatic
force-pushed
the
predict-in-binary
branch
3 times, most recently
from
33925aa to
61f5598
Compare
This change now looks at all the flags on the command line and uses previous flags to filter results for the current flag. We now honor: * -S/--sso * -R/--role * -A/--account Which impacts the --role, --account, --profile and --arn flags. Refactor our code and move all predction code into internal/predictor Fixes: #382
synfinatic
force-pushed
the
predict-in-binary
branch
from
61f5598 to
6d213f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change now looks at all the flags on the command line and uses
previous flags to filter results for the current flag. We now
honor:
Which impacts the --role, --account, --profile and --arn flags.
Refactor our code and move all predction code into internal/predictor
Fixes: #382