Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic if UrlExecCommand is not set during config #386

Merged
merged 1 commit into from
May 9, 2022

Conversation

synfinatic
Copy link
Owner

Never will support UrlExecCommand as a single string, so simply the code to be []string so we don't have to deal with interface{}

Fixes #385

@synfinatic synfinatic added this to the 1.9.1 milestone May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #386 (df9e2f5) into main (71a97d1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   76.00%   76.09%   +0.09%     
==========================================
  Files          18       18              
  Lines        2279     2288       +9     
==========================================
+ Hits         1732     1741       +9     
  Misses        480      480              
  Partials       67       67              
Impacted Files Coverage Δ
sso/awssso.go 65.96% <ø> (ø)
sso/settings.go 67.32% <ø> (ø)
internal/utils/url.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a97d1...df9e2f5. Read the comment docs.

@synfinatic synfinatic force-pushed the config-panic branch 2 times, most recently from 980acda to c50ca86 Compare May 9, 2022 18:31
- Dont generate warning if icon/color aren't set

Fixes #385
@synfinatic synfinatic merged commit bf184e2 into main May 9, 2022
@synfinatic synfinatic deleted the config-panic branch May 9, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when running config
1 participant