Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor logger and fix History tag expiration (WIP) #307

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

synfinatic
Copy link
Owner

@synfinatic synfinatic commented Mar 22, 2022

  • Use an instance of logrus instead of the module in cmd & sso to
    aid in unit tests
  • Add a ton of unit tests for expiring history
  • Fix "too few fields for role History Tag: ""

Refs: #305

@synfinatic
Copy link
Owner Author

WIP. just getting stats on unit test coverage for now

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #307 (0ff3acd) into main (9f5bb3e) will increase coverage by 2.46%.
The diff coverage is 78.94%.

❗ Current head 0ff3acd differs from pull request most recent head dc2b9d7. Consider uploading reports for the commit dc2b9d7 to get more accurate results

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   68.05%   70.52%   +2.46%     
==========================================
  Files          12       15       +3     
  Lines        1916     1944      +28     
==========================================
+ Hits         1304     1371      +67     
+ Misses        544      509      -35     
+ Partials       68       64       -4     
Impacted Files Coverage Δ
sso/awssso.go 65.81% <ø> (ø)
sso/awssso_auth.go 80.45% <ø> (ø)
sso/options.go 0.00% <ø> (ø)
sso/roles.go 74.44% <ø> (+2.20%) ⬆️
sso/tags_list.go 70.12% <ø> (ø)
storage/json_store.go 85.07% <ø> (ø)
storage/keyring.go 84.57% <ø> (ø)
storage/storage.go 86.95% <ø> (ø)
utils/utils.go 96.77% <ø> (-0.02%) ⬇️
sso/settings.go 61.53% <20.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5bb3e...dc2b9d7. Read the comment docs.

@synfinatic synfinatic force-pushed the history-tag branch 5 times, most recently from 3e68bf0 to 0ff3acd Compare March 23, 2022 04:36
- Use an instance of logrus instead of the module
- Add a ton of unit tests for expiring history
- Fix "too few fields for role History Tag: ""???

We no longer generate an error and any empty History
tag is effectively ignored.

Refs: #305
@synfinatic synfinatic merged commit b4140b6 into main Mar 23, 2022
@synfinatic synfinatic deleted the history-tag branch March 23, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant